Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up corner cases in table and code unescaping #776

Merged
merged 2 commits into from Jan 21, 2024

Conversation

notriddle
Copy link
Collaborator

Fixes #716

@Martin1887
Copy link
Collaborator

This feels right to me, but it is a pretty big change and I would like the approval of @raphlinus.

This was a blocking issue for the 0.10 version, so it is closer. Thanks!

Copy link
Collaborator

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dauntingly large change for a relatively edge-casey bug, but I can't quickly see a better way to fix it. I'm satisfied with the degree of testing.

Note, the merge conflicts will need to be fixed before merging.

@Martin1887 Martin1887 merged commit c94557a into pulldown-cmark:master Jan 21, 2024
1 check passed
@notriddle notriddle deleted the notriddle/unescape branch January 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline code loses backslashes on subsequent lines
3 participants