Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate escape.rs in another crate #838

Merged
merged 3 commits into from Feb 3, 2024
Merged

feat: separate escape.rs in another crate #838

merged 3 commits into from Feb 3, 2024

Conversation

Martin1887
Copy link
Collaborator

Fixes: #526.

@Martin1887
Copy link
Collaborator Author

Finally!, the last pending issue for the 0.10 release. Please, @notriddle, review it if you have a chance :-).

@Martin1887 Martin1887 merged commit 67a1407 into master Feb 3, 2024
1 check passed
@Martin1887 Martin1887 deleted the fix-526 branch February 3, 2024 09:50
@laurmaedje
Copy link

The "Breaking changes" section in the changelog should maybe be updated to mention this. It states that the escape module is now optional, which was true between #519 and this, but is a bit misleading now. I was previously using the pulldown_cmark::escape module directly and it stopped working after updating to 0.10.

@Martin1887
Copy link
Collaborator Author

Right, thanks, it was in new features but it is also a breaking change. It is already updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider breaking html escaping into subcrate?
3 participants
@Martin1887 @laurmaedje @notriddle