Alias for installing bindings #210

fao89 · 2020-01-25T13:18:17Z

https://pulp.plan.io/issues/6032
closes #6032

How to use:

pbindings pulp_file python
it will install pulpcore and pulp_file python bindings

bmbouter · 2020-01-27T14:45:57Z

@fabricio-aguiar to confirm, this will only occur in dev installs right?

fao89 · 2020-01-27T14:49:12Z

@fabricio-aguiar to confirm, this will only occur in dev installs right?

yes, all my changes were on pulp-devel role,
after this PR is merged, pulplift will need an update here:
https://github.com/pulp/pulplift/blob/master/example.dev-config.yml
adding binding option:

pulp-file:
    binding: pulp-file-client
    source_dir: "/home/vagrant/devel/pulp_file"

bmbouter · 2020-01-27T14:50:20Z

@fabricio-aguiar can you open a pulplift PR I can test with this also?

fao89 · 2020-01-27T14:55:57Z

@fabricio-aguiar can you open a pulplift PR I can test with this also?

I can do it, but if you have a local.dev-config.yml, it will overwrite example.dev-config.yml

bmbouter · 2020-01-27T14:58:11Z

I will test using the example.dev-config.yml

fao89 · 2020-01-27T15:16:20Z

example.dev-config

here:
https://github.com/pulp/pulplift/pull/62/files

bmbouter · 2020-01-27T15:21:05Z

Thanks! I'm testing it now.

bmbouter · 2020-01-27T15:49:15Z

pulp_file worked for me!

[vagrant@pulp3-source-fedora31 ~]$ workon pulp
(pulp) [vagrant@pulp3-source-fedora31 ~]$ python
Python 3.7.4 (default, Aug 12 2019, 14:45:07) 
[GCC 9.1.1 20190605 (Red Hat 9.1.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pulpcore.client import pulp_file
>>> dir(pulp_file)
['ApiClient', 'ApiException', 'ApiKeyError', 'ApiTypeError', 'ApiValueError', 'AsyncOperationResponse', 'Configuration', 'ContentFilesApi', 'ContentSummary', 'DistributionsFileApi', 'FileExportersFileApi', 'FileFileContent', 'FileFileDistribution', 'FileFileFileSystemExporter', 'FileFilePublication', 'FileFileRemote', 'FileFileRepository', 'InlineResponse200', 'InlineResponse2001', 'InlineResponse2002', 'InlineResponse2003', 'InlineResponse2004', 'InlineResponse2005', 'InlineResponse2006', 'OpenApiException', 'PublicationExport', 'PublicationsFileApi', 'RemotesFileApi', 'RepositoriesFileApi', 'RepositoriesFileVersionsApi', 'RepositoryAddRemoveContent', 'RepositorySyncURL', 'RepositoryVersion', '__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__', '__version__', 'absolute_import', 'api', 'api_client', 'configuration', 'exceptions', 'models', 'rest']
>>>

bmbouter · 2020-01-27T15:58:09Z

Do these installations come from PyPI in some cases? I think we want them to be from source installs in all cases.

bmbouter · 2020-01-27T16:06:21Z

roles/pulp-devel/handlers/main.yml

@@ -0,0 +1,6 @@
+---
+- name: Install pulpcore binding package via PyPI


I think this needs to be built from local source

bmbouter · 2020-01-27T16:06:48Z

roles/pulp-devel/tasks/main.yml

+      with_dict: "{{ pulp_install_plugins }}"
+      when: item.value.binding is defined
+      notify:
+        - Install pulpcore binding package via PyPI


I think this needs to be done via local source

without pulpcore binding, any plugin binding would be useless, because tests need pulpcore binding also

Yes I just imagined it would come from a local checkout of pulpcore. Perhaps I'm thinking that is normal because I'm usually working on pulpcore and need the source install there, but other devs maybe don't.

my idea with this is to assure the dev will have the env ready for running functional tests as soon it is provisioned, that is how I understood: https://pulp.plan.io/issues/6032#note-2

I imagined it pbindings would be called late in the dev setup process. That would be better I think because then the bindings version received matches the version of pulpcore they are actually running. It also would be simpler because you can just let pbindings do it all.

When I saw late in the process I mean after Pulp is running because it needs to provide the openAPI schema

bmbouter · 2020-01-27T16:07:05Z

roles/pulp-devel/templates/alias.bashrc.j2

+    fi
+
+    ./generate.sh $@
+    pip install ./$1-client


This actually does use the local source, so this part is good.

bmbouter · 2020-01-27T16:07:52Z

roles/pulp-devel/templates/alias.bashrc.j2

@@ -144,3 +144,32 @@ pyclean () {
        find . -type d -name "__pycache__" -delete
 }
 _pyclean_help="Cleanup extra python files"
+
+pbindings(){


Does making some way to install, uninstall, or reinstall make any sense. As code changes in PRs it would be convenient to have 1 command to reinstall that plugins' bindings. What do you think?

the command is idempotent, so for reinstall, you just need to call it again

oh nice that makes it simple which is great. No changes needed here.

https://pulp.plan.io/issues/6032 closes #6032

bmbouter · 2020-01-27T22:17:53Z

I tested this and it worked well for me. The vagrant up worked, and also pbindings pulp_file python reinstalled them for me.

bmbouter · 2020-01-27T22:18:57Z

It's hard to tell the bindings are not coming from PyPI with pip freeze but I can see them building so I know it's right. Them showing in a confusing way with pip freeze I think is a separate problem.

fao89 · 2020-01-27T22:20:27Z

It's hard to tell the bindings are not coming from PyPI with pip freeze but I can see them building so I know it's right. Them showing in a confusing way with pip freeze I think is a separate problem.

from PyPI it has version number, building locally the version is 0.0.0

fao89 requested review from bmbouter and mikedep333 January 27, 2020 13:11

bmbouter reviewed Jan 27, 2020

View reviewed changes

Alias for installing bindings

0f12eb8

https://pulp.plan.io/issues/6032 closes #6032

bmbouter merged commit d7ef46b into pulp:master Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alias for installing bindings #210

Alias for installing bindings #210

fao89 commented Jan 25, 2020 •

edited

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter Jan 27, 2020

bmbouter Jan 27, 2020

fao89 Jan 27, 2020

bmbouter Jan 27, 2020

fao89 Jan 27, 2020

bmbouter Jan 27, 2020

bmbouter Jan 27, 2020

bmbouter Jan 27, 2020

bmbouter Jan 27, 2020

fao89 Jan 27, 2020

bmbouter Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

		@@ -0,0 +1,6 @@
		---
		- name: Install pulpcore binding package via PyPI

Alias for installing bindings #210

Alias for installing bindings #210

Conversation

fao89 commented Jan 25, 2020 • edited

How to use:

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmbouter commented Jan 27, 2020

bmbouter commented Jan 27, 2020

fao89 commented Jan 27, 2020

fao89 commented Jan 25, 2020 •

edited