This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Alias for installing bindings #210
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,3 +144,34 @@ pyclean () { | |
find . -type d -name "__pycache__" -delete | ||
} | ||
_pyclean_help="Cleanup extra python files" | ||
|
||
pbindings(){ | ||
CURRENT_DIR=$(pwd) | ||
|
||
if [ -d $HOME/devel/pulp-openapi-generator ] | ||
then | ||
cd $HOME/devel/pulp-openapi-generator | ||
else | ||
cd $HOME/devel | ||
git clone https://github.com/pulp/pulp-openapi-generator.git | ||
cd pulp-openapi-generator | ||
fi | ||
|
||
sed -i 's/docker/podman/g' generate.sh | ||
workon pulp | ||
|
||
if [ $1 != 'pulpcore' ] | ||
then | ||
sudo ./generate.sh pulpcore $2 | ||
pip install ./pulpcore-client | ||
sudo rm -rf pulpcore-client | ||
fi | ||
|
||
sudo ./generate.sh $@ | ||
pip install ./$1-client | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This actually does use the local source, so this part is good. |
||
sudo rm -rf $1-client | ||
|
||
sed -i 's/podman/docker/g' generate.sh | ||
cd $CURRENT_DIR | ||
} | ||
_pbindings_help="Install bindings" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does making some way to
install
,uninstall
, orreinstall
make any sense. As code changes in PRs it would be convenient to have 1 command to reinstall that plugins' bindings. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the command is idempotent, so for reinstall, you just need to call it again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice that makes it simple which is great. No changes needed here.