Fix up pulp_user when installing under vagrant

closes #4324
https://pulp.plan.io/issues/4324

molecule/default/molecule.yml

@@ -13,12 +13,6 @@ platforms:
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:ro
     command: /usr/sbin/init
-  - name: fedora-27
-    image: fedora:27
-    privileged: True
-    volumes:
-      - /sys/fs/cgroup:/sys/fs/cgroup:ro
-    command: /usr/sbin/init
   - name: fedora-28
     image: fedora:28
     privileged: True

requirements.yml

@@ -1,4 +1,4 @@
 ---
-- src: https://github.com/ehelms/ansible-role-postgresql
-  version: add-scl-support
+- src: https://github.com/dralley/ansible-role-postgresql
+  version: master
   name: geerlingguy.postgresql

roles/pulp3-devel/files/settings.json

@@ -0,0 +1,34 @@
+{
+  "hosts": [
+    {
+      "hostname": "localhost",
+      "roles": {
+        "api": {
+          "port": 8000,
+          "scheme": "http",
+          "service": "nginx",
+          "verify": false
+        },
+        "content": {
+          "port": 8080,
+          "scheme": "http",
+          "service": "pulp_content_app",
+          "verify": false
+        },
+        "pulp resource manager": {},
+        "pulp workers": {},
+        "redis": {},
+        "shell": {
+          "transport": "local"
+        }
+      }
+    }
+  ],
+  "pulp": {
+    "auth": [
+      "admin",
+      "password"
+    ],
+    "selinux enabled": false,
+    "version": "3"
+  }

roles/pulp3-devel/tasks/main.yml

@@ -53,12 +53,25 @@
         virtualenv: '{{ pulp_install_dir }}'
         virtualenv_command: '{{ pulp_python_interpreter }} -m venv'
 
-    - name: Install pulp-smash for testing locally
+
+    - name: Install requirements for testing locally
+      pip:
+        requirements: '{{ pulp_source_dir }}/test_requirements.txt'
+        state: present
+        virtualenv: '{{ pulp_install_dir }}'
+        virtualenv_command: '{{ pulp_python_interpreter }} -m venv'
+
+    - name: Install requirements for developer scripts
       pip:
-        name: pulp-smash
+        requirements: '{{ pulp_source_dir }}/dev_requirements.txt'
+        state: present
         virtualenv: '{{ pulp_install_dir }}'
         virtualenv_command: '{{ pulp_python_interpreter }} -m venv'
 
+      retries: "{{ package_retries }}"
+      register: result
+      until: result is succeeded
+
   become: true
   become_user: '{{ pulp_user }}'
 
@@ -116,6 +129,17 @@
         force: yes
         mode: 0600
 
+    - name: Create pulp-smash config directory if not already present
+      file:
+        path: "{{ developer_user_home }}/.config/pulp_smash/"
+        state: directory
+        recurse: yes
+
+    - name: Create pulp-smash config if not already present
+      copy:
+        src: files/settings.json
+        dest: "{{ developer_user_home }}/.config/pulp_smash/settings.json"
+
   become: true
   become_user: "{{ developer_user }}"
 #

roles/pulp3-devel/templates/alias.bashrc.j2

@@ -32,7 +32,7 @@ pclean() {
     workon pulp
     pulp-manager reset_db --noinput
     pulp-manager migrate
-    pulp-manager reset-admin-password --password admin
+    pulp-manager reset-admin-password --password {{ pulp_admin_default_password }}
 }
 _pclean_help="Restore pulp to a clean-installed state"
 # can get away with not resetting terminal settings here since it gets reset in phelp

roles/pulp3-postgresql/meta/main.yml

@@ -10,9 +10,9 @@ galaxy_info:
     - name: Fedora
       versions:
         - all
-    - name: Debian
-      versions:
-        - stretch
+  # - name: Debian
+  #   versions:
+  #     - stretch
   galaxy_tags:
     - pulp3
 dependencies:

roles/pulp3-postgresql/vars/main.yml

@@ -3,9 +3,9 @@
 
 postgresql_databases:
   - name: '{{ pulp_database_config["default"]["NAME"] }}'
+    owner: '{{ pulp_database_config["default"]["NAME"] }}'
 
 postgresql_users:
   - name: '{{ pulp_database_config["default"]["USER"] }}'
     password: '{{ pulp_database_config["default"]["PASSWORD"] }}'
-    db: '{{ pulp_database_config["default"]["NAME"] }}'
-    priv: ALL
+    role_attr_flags: CREATEDB

roles/pulp3/meta/main.yml

@@ -10,9 +10,10 @@ galaxy_info:
     - name: Fedora
       versions:
         - all
-    - name: Debian
-      versions:
-        - stretch
+  # Not supported yet because Debian ships with Python 3.5 (< 3.6 Pulp minimum version)
+  # - name: Debian
+  #   versions:
+  #     - stretch
   galaxy_tags:
     - pulp3
     - pulpcore

roles/pulp3/tasks/install.yml

@@ -31,6 +31,7 @@
         shell: '{{ result.stdout.strip() }}'
         home: '{{ pulp_var_dir }}'
         system: true
+      when: developer_user is not defined
 
     - name: Create temp dir for Pulp
       file:

source-install.yml

@@ -5,17 +5,21 @@
     developer_user_home: "/home/vagrant"
     package_retries: "5"
     pulp_default_admin_password: password
+    pulp_devel_supplement_bashrc: true
     pulp_install_plugins:
       # pulp-python:
       #   app_label: "python"
       #   source_dir: "/home/vagrant/devel/pulp_python"
+      # pulp-rpm:
+      #   app_label: "rpm"
+      #   source_dir: "/home/vagrant/devel/pulp_rpm"
       pulp-file:
         app_label: "file"
         source_dir: "/home/vagrant/devel/pulp_file"
     pulp_plugin_source_dir: "/home/vagrant/devel/pulpcore-plugin"
     pulp_secret_key: "unsafe_default"
     pulp_source_dir: "/home/vagrant/devel/pulp"
-    pulp_devel_supplement_bashrc: true
+    pulp_user: "vagrant"
   pre_tasks:
     - name: Set up Vagrant machine for source installs
       include: vagrant-pretask.yml

vagrant-pretask.yml

@@ -1,5 +1,5 @@
 ---
-- name: Make user's home directory world-readable
+- name: (Vagrant) Make user's home directory world-readable
   file:
     path: "{{ ansible_env.HOME }}"
     state: directory