1958 - Add checks in rpm scripts to only restorecon if the /var/lib/c… #62
Conversation
|
Please add your name to the AUTHORS file. https://github.com/pulp/crane/blob/master/AUTHORS |
…rane directory exits
|
@mhrivnak done, and pushed. |
|
@mhrivnak how do I debug that errors, looks like environmental? |
|
@bkearney Can you clarify this comment? Are you saying the root cause could have been environmental and this is not needed? |
|
@bmbouter the failures looked to be environmental. Am I reading that incorrectly? |
|
Oh you mean the travis failures. I'm not very familiar with crane's test runner myself, but let me look at it. |
|
I think they are environmental (specific to Travis), but they are also repeatable. I also ran the tests locally in my Vagrant environment and they all pass. Which means that it is environmental on Travis specifically. I rebased your commit and pushed it through my fork of crane so that I could get Travis to make another build of it and it failed with the exact same reason. Also other builds are passing. I'm testing the parent on Travis to see if the issue is introduced with this PR specifically. |
|
I have reproduced the Travis issue from a commit based on the parent of your commit and it failed for the same reason. On that basis I am going to merge this since it looks right to me and the test failure is not related. We will then handle the failing Travis environment on master as a separate issue. Merging! |
|
I touched up the commit message some to include Redmine integration keywords so I am merging as PR #63 from my branch. Your original author info on the commit was maintained. |
…rane directory exits