Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
/ devel Public archive

Revert "Adding sqlite binary to dev env" #151

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

daviddavis
Copy link
Contributor

This reverts commit fe68c0a.

fixes #3505
https://pulp.plan.io/issues/3505

Copy link

@Ichimonji10 Ichimonji10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, though it's not a silver bullet for database issues.

@Ichimonji10
Copy link

When I say that this is "not a silver bullet for database issues," what I mean is that I'm still encountering issues such as database locks when executing tests. Here's a snippet from one traceback:

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/db/backends/sqlite3/base.py", line 303, in execute
    return Database.Cursor.execute(self, query, params)
django.db.utils.OperationalError: database is locked

@dralley
Copy link
Contributor

dralley commented Apr 26, 2018

@Ichimonji10 I don't think it's intended as a fix to the sqlite issue, just part of the switch back to postgres.

@Ichimonji10
Copy link

Ichimonji10 commented Apr 26, 2018

This PR states that it fixes https://pulp.plan.io/issues/3505. Is that a mis-characterization? Or am I mis-understanding?

@dralley
Copy link
Contributor

dralley commented Apr 26, 2018

The intended action for 3505 was originally to have the devel environment install some override config that would use Postgres as default instead. That never happened. What's happening now is that the actual default is being switched back to Postgres (on the Pulp side) and so the only thing to do here is remove the code which was installing the sqlite binary.

But the default will still be sqlite until the PR on Pulpcore gets merged.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this against the core PR and they both tested great. I'm merging so I can rebase other work that is failing.

@bmbouter bmbouter merged commit c88fbdc into pulp:3.0-dev Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants