This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Ansible now looks for the pulp/packaging repo for specs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremycline, thanks for your PR! By analyzing the annotation information on this pull request, we identified @seandst to be a potential reviewer |
| raise OSError(str(platform_dist) + ' is not a supported development platform') | ||
|
|
||
|
|
||
| packaging_repo = os.path.join(user_homedir, 'devel/packaging/') |
There was a problem hiding this comment.
I'm on the fence about requiring the packaging repository to be checked out here. The alternative is to check it out in a temporary location and not rely on the user to clone it.
|
Also note the dev guide will need an update if we decide to require the packaging repo. |
In 3.0-dev branches, the spec files have been removed from the project repositories. Ansible needs to look in the packaging repository to gather the list of dependencies.
jeremycline
force-pushed
the
fix-3.0-ansible
branch
from
182fdb2
to
1a19a9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.0-dev branches, the spec files have been removed from the project
repositories. Ansible needs to look in the packaging repository to
gather the list of dependencies.