This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Jconnor threaded downloader #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemonized all spawned threads
changed worker queue to support iterable, iterators, and generators without having to "cast" to an interator with iter()
… with this queue and substituted it with thread-safe event firing and join()s on the worker threads
| # done! | ||
| break | ||
| report_func(report) | ||
| queue.task_done() | ||
|
|
There was a problem hiding this comment.
we have an extra blank line here
There was a problem hiding this comment.
These are lines that were removed, not added
|
Just some minor things. Merge when done with those. Thanks! |
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed feeder and reporter threads due to race conditions.
Replaced with simple thread-safe wrapper around request_list and thread-safe version for _fire_event_to_listener