-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the gunicorn timeout for pulpcore-api to 10 minutes #112
Conversation
It is necessary to re-build the image after applying this change. closes pulp#69
@@ -13,4 +13,4 @@ export PULP_SETTINGS /etc/pulp/settings.py | |||
export HOME /var/lib/pulp/ | |||
|
|||
# TODO: Modify OCI base image to allow for auto reload to be configurable so we don't have to override this. | |||
/usr/local/bin/gunicorn pulpcore.app.wsgi:application --bind "127.0.0.1:24817" --name pulp-api --access-logfile - --access-logformat "pulp [%({correlation-id}o)s]: %(h)s %(l)s %(u)s %(t)s \"%(r)s\" %(s)s %(b)s \"%(f)s\" \"%(a)s\"" --reload | |||
/usr/local/bin/gunicorn pulpcore.app.wsgi:application --bind "127.0.0.1:24817" --timeout 600 --name pulp-api --access-logfile - --access-logformat "pulp [%({correlation-id}o)s]: %(h)s %(l)s %(u)s %(t)s \"%(r)s\" %(s)s %(b)s \"%(f)s\" \"%(a)s\"" --reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is not used (or was expected to) anymore. The file for that modification is /etc/init/pulpcore-api
and we have an envvar for gunicorn timeout(PULP_GUNICORN_TIMEOUT
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the place where we copy the service to the container:
Line 22 in 508344b
COPY s6-rc-modifications/pulpcore-api/run /etc/s6-overlay/s6-rc.d/pulpcore-api/run |
I think this is the right place to make the modification. After re-building the image, the changes are present in the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it works because we still didn't merged this yet #100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to use the envar. the default should stay as is ( which is 30 sec, i think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge #100, we should be able to set --reload
and --timeout
from the compose.yaml file. I can then close this PR along with the referenced issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value can be now set from compose.env
by overriding the PULP_GUNICORN_TIMEOUT
environment variable. Therefore, I am closing the PR because of 2cbc9ec#diff-b093d34eec92adf6e0cc6e445edb7147ea45d25fb0c98f2f84a60f5aae6f34f7L22.
It is necessary to re-build the image after applying this change.
closes #69