This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Add setuptools, pkginfo, and twine to el6 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't even know where to start when it comes to reviewing spec files. Got any pointers? |
|
Yeah, although it's a lot of reading unfortunately. I also pulled all these specs from Fedora or CentOS packages (for example, https://admin.fedoraproject.org/pkgdb/package/rpms/python-twine/ should link to the initial package review, the current dist-git repository, and existing builds, and https://git.centos.org/summary/rpms!python-setuptools is the CentOS dist-git) so you could just make sure the diff between those is sane. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.