include additional plugins on travis #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
reviewed
Oct 2, 2019
| @@ -69,6 +76,8 @@ images: | |||
| plugins: | |||
| - pulp-certguard | |||
There was a problem hiding this comment.
Let's remove pulp-certguard and have it be provided by the additional_plugins config for each plugin.
fao89
commented
Oct 2, 2019
| @@ -15,6 +15,7 @@ from jinja2 import Environment, FileSystemLoader | |||
|
|
|||
|
|
|||
| DEFAULT_SETTINGS = { | |||
| 'additional_plugins': [], | |||
There was a problem hiding this comment.
@dkliban what do you think about making pulp-certguard default?
'additional_plugins': ['pulp-certguard'],
There was a problem hiding this comment.
Let's leave it empty for now. However, when we update the template_config.yml for pulpcore, we definitely want to add 'pulp-certguard' to hte list there.
dkliban
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5500
https://pulp.plan.io/issues/5500