Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing github actions #182

Closed
wants to merge 1 commit into from
Closed

Introducing github actions #182

wants to merge 1 commit into from

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Feb 11, 2020 •
edited

@dralley
Copy link
Contributor

dralley commented Feb 11, 2020

Looks good, although we won't want to keep Travis running for long afterwards due to the duplication of the scripts.

@fao89 fao89 mentioned this pull request Feb 12, 2020
Merged
mdellweg
mdellweg reviewed Apr 8, 2020
View reviewed changes
.travis/before_install.sh
# bootstrap.py to update this file.
#
# For more info visit https://github.com/pulp/plugin_template

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this header be removed?
The reference to bootstrap.py is wrong though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not from the template, it is the CI config for plugin_template itself, and it has some differences from the one generated from template.

@mdellweg
Copy link
Member

mdellweg commented Apr 8, 2020

The scripts copied from travis to gh-actions look mostly identical to me.
Would it be feasible to make them ci-agnostic and put them in a common location?

@fao89
Copy link
Member Author

fao89 commented Apr 8, 2020

The scripts copied from travis to gh-actions look mostly identical to me.
Would it be feasible to make them ci-agnostic and put them in a common location?

This PR started as PoC, and many things changed after I started it, I believe we will remove travis entirely

@fao89
Copy link
Member Author

fao89 commented Apr 15, 2020

Waiting github actions features

@fao89 fao89 closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg left review comments

Assignees
No one assigned
Labels
Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fao89 @dralley @mdellweg