Add ability to have custom lint checks #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmclaughlin
force-pushed
the
add-extra-linting
branch
from
58711ed
to
8cd09ae
Compare
bmclaughlin
force-pushed
the
add-extra-linting
branch
from
8cd09ae
to
e64e5f0
Compare
mdellweg
reviewed
Feb 22, 2022
| @@ -0,0 +1 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
That's not the way it will work. This file will be wiped all the time by the plugin template.
| @@ -71,6 +71,11 @@ jobs: | |||
| run: flake8 --config flake8.cfg | |||
| {%- endif %} | |||
|
|
|||
| {% if extra_linting -%} | |||
| - name: Run extra lint checks | |||
| run: sh .ci/scripts/extra_linting.sh | |||
There was a problem hiding this comment.
How about something like [ -x .ci/scripts/extra_linting.sh] && .ci/scripts/extra_linting.sh?
bmclaughlin
force-pushed
the
add-extra-linting
branch
from
e64e5f0
to
ec914d7
Compare
bmclaughlin
force-pushed
the
add-extra-linting
branch
2 times, most recently
from
d83a09a
to
db7a3df
Compare
mdellweg
reviewed
Feb 23, 2022
CHANGES/572.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Add ability to perform custom lint checks | |||
There was a problem hiding this comment.
Suggested change
| Add ability to perform custom lint checks | |
| Added the ability to perform custom lint checks. |
| @@ -71,6 +71,11 @@ jobs: | |||
| run: flake8 --config flake8.cfg | |||
| {%- endif %} | |||
|
|
|||
| {% if extra_linting -%} | |||
| - name: Run extra lint checks | |||
| run: [ -x .ci/scripts/extra_linting.sh] && .ci/scripts/extra_linting.sh | |||
There was a problem hiding this comment.
Suggested change
| run: [ -x .ci/scripts/extra_linting.sh] && .ci/scripts/extra_linting.sh | |
| run: [ -x .ci/scripts/extra_linting.sh ] && .ci/scripts/extra_linting.sh |
plugin-template
Outdated
| @@ -22,6 +22,7 @@ DEFAULT_SETTINGS = { | |||
| "upgrade_range": [], | |||
| "black": True, | |||
| "flake8": True, | |||
| "extra_linting": False, | |||
There was a problem hiding this comment.
I don't think we need the double guard here.
bmclaughlin
force-pushed
the
add-extra-linting
branch
from
db7a3df
to
2e8d559
Compare
mdellweg
reviewed
Feb 23, 2022
Comment on lines
74
to
77
| {% if extra_linting -%} | ||
| - name: Run extra lint checks | ||
| run: [ -x .ci/scripts/extra_linting.sh ] && .ci/scripts/extra_linting.sh | ||
| {%- endif %} |
There was a problem hiding this comment.
Sorry, forgot to mention: You need to remove the ifs and the docs for this flag again.
The whole PR would just be lines 75-76 (and the changelog).
bmclaughlin
force-pushed
the
add-extra-linting
branch
from
2e8d559
to
963dc43
Compare
mdellweg
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #572