Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Commit

Permalink
Fix the bindings on the pulp2repositories API
Browse files Browse the repository at this point in the history
  • Loading branch information
dralley committed Jan 30, 2020
1 parent 5ca0204 commit 140395f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES/6049.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the bindings for publication and distribution hrefs fields on pulp2repositories API.
9 changes: 7 additions & 2 deletions pulp_2to3_migration/app/serializers.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json

from drf_yasg.utils import swagger_serializer_method
from gettext import gettext as _
from django.urls import reverse
from jsonschema import Draft7Validator
Expand Down Expand Up @@ -169,13 +170,15 @@ class Pulp2RepositoriesSerializer(ModelSerializer):
pulp3_distribution_hrefs = serializers.SerializerMethodField(read_only=True)
pulp3_repository_href = serializers.SerializerMethodField(read_only=True)

@swagger_serializer_method(serializer_or_field=serializers.CharField)
def get_pulp3_repository_href(self, obj):
"""
Get pulp3_repository_href from pulp2repo
"""
repository = obj.pulp3_repository_version.repository
return get_pulp_href(repository)

@swagger_serializer_method(serializer_or_field=serializers.CharField)
def get_pulp3_remote_href(self, obj):
"""
Get pulp3_remote_href from pulp2repo
Expand All @@ -185,13 +188,15 @@ def get_pulp3_remote_href(self, obj):
return None
return get_pulp_href(remote)

@swagger_serializer_method(serializer_or_field=serializers.CharField)
def get_pulp3_publication_href(self, obj):
"""
Get pulp3_publication_href from pulp3_repository_version
"""
pub_list = obj.pulp3_repository_version.publication_set.all()
return [get_pulp_href(pub) for pub in pub_list]
return get_pulp_href(obj.pulp3_repository_version.publication_set.first())

@swagger_serializer_method(
serializer_or_field=serializers.ListField(child=serializers.CharField()))
def get_pulp3_distribution_hrefs(self, obj):
"""
Get pulp3_distribution_hrefs from pulp3_repository_version
Expand Down

0 comments on commit 140395f

Please sign in to comment.