Fixes #497 - local variable 'item' referenced before assignment

pulp · Jan 12, 2022 · 72a6325 · 72a6325
1 parent 18b974a
commit 72a6325
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/CHANGES/497.bugfix b/CHANGES/497.bugfix
@@ -0,0 +1 @@
+Fixed local variable 'item' referenced before assignment
diff --git a/pulp_2to3_migration/app/plugin/docker/migrator.py b/pulp_2to3_migration/app/plugin/docker/migrator.py
@@ -233,18 +233,17 @@ def relate_manifest_to_list(self, dc):
             digest = manifest['digest']
             for item in man_list:
                 if item.digest == digest:
+                    platform = manifest['platform']
+                    thru = ManifestListManifest(manifest_list=item, image_manifest=dc.content,
+                                                architecture=platform['architecture'],
+                                                os=platform['os'],
+                                                features=platform.get('features', ''),
+                                                variant=platform.get('variant', ''),
+                                                os_version=platform.get('os.version', ''),
+                                                os_features=platform.get('os.features', '')
+                                                )
+                    mlm.append(thru)
                     break
-            platform = manifest['platform']
-            thru = ManifestListManifest(manifest_list=item, image_manifest=dc.content,
-                                        architecture=platform['architecture'],
-                                        os=platform['os'],
-                                        features=platform.get('features', ''),
-                                        variant=platform.get('variant', ''),
-                                        os_version=platform.get('os.version', ''),
-                                        os_features=platform.get('os.features', '')
-                                        )
-            mlm.append(thru)
-
         return mlm