-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
178e1c0
to
9188bee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulp2 rpm and errata models lgtm!
pulp2_type = 'erratum' | ||
|
||
class Meta: | ||
default_related_name = 'erratum_detail_model' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goosemania we need to add here properties expected_size, expected_digests, relative_path_for_content_artifact
because later code would fail whenever it will try to access those. As far as i understood we won't really use them since errata will be split in pulp3, so we'd just need to return none or {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I hoped errata migration code will take care of that, since I can't test errata now.
setup.py
Outdated
@@ -36,7 +36,8 @@ | |||
], | |||
'migrators': [ | |||
'iso = pulp_2to3_migration.app.plugin.iso.migrator:IsoMigrator', | |||
'docker = pulp_2to3_migration.app.plugin.docker.migrator:DockerMigrator', | |||
# 'docker = pulp_2to3_migration.app.plugin.docker.migrator:DockerMigrator', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's is the reason this is commented out? please make sure it is uncommented when you merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's commented out because it doesn't work for the pulpcore master branch (does_batch issue) + it was not possible to install it at some point.
Actually, maybe now it's installable since the pulpcore version in pulp_container has been fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
# ensure that the base_path does not end with / in Pulp 3, it's often present in Pulp 2. | ||
base_path = pulp2_config.get( | ||
'relative_url', pulp2distributor.pulp2_repo_id) | ||
if base_path.endswith('/'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about using base_path.rstrip('/')?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@goosemania thank you, these changes make sense. please address minor comments and go ahead and merge! 🌴 🍺 |
Docker plugin is temporarily commented out in the setup.py until the support for pulpcore 3.1 is added. closes #6174 https://pulp.plan.io/issues/6174
closes #6175 https://pulp.plan.io/issues/6175
9188bee
to
3227a8d
Compare
closes #6177 https://pulp.plan.io/issues/6177
3227a8d
to
9ffba73
Compare
From all RPM content, only RPM packages are migrated at the moment.