Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Migrate relationship between repo and importer to Pulp 3 #356

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Apr 24, 2021

Populate the "remote" field on the Pulp 3 repository model with the
information stored in the Pulp2Repositories table, so that it can
survive post-migration.

closes: #8626
https://pulp.plan.io/issues/8626

@dralley dralley force-pushed the migrate-remote-info branch 7 times, most recently from a0cadf5 to bfc282b Compare April 25, 2021 02:59
if pulp3_remote:
pulp2_repo.pulp3_repository_remote = pulp3_remote
pulp2_repo.save()

pulp3_repo.remote = pulp3_remote
pulp3_repo.save()
Copy link
Contributor

@quba42 quba42 May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it, but I am pretty sure this won't work for released versions of pulp_deb and possibly other plugins. In Pulp 3 each plugin needs to provide a list of REMOTE_TYPES for which this association should be available. For any remote types not in the list, an error is thrown. For pulp_deb I only happened to stumble across this recently (See pulp/pulp_deb#261) and it has not yet been released.

If we want to add this change, I will need to backport this feature/fix to all pulp_deb versions that I want people to be able to migrate from, so keep me in the loop.

Copy link
Contributor Author

@dralley dralley Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quba42 This appears to be released now, is that correct?

I don't think backports are necessary, we have a hard cutoff in terms of plugin support due to the distribution changes.

Copy link
Member

@goosemania goosemania Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quba42 , this is planned to go into 0.12 release which will be compatible with pulpcore 3.12-3.14.
This release will no longer be compatible with Katello. They are staying on 0.11.z and won't go beyond that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pulp_deb change was released with version 2.12.0 which is compatible with pulpcore>=3.12,<3.14, so that should line up nicely.

Populate the "remote" field on the Pulp 3 repository model with the
information stored in the Pulp2Repositories table, so that it can
survive post-migration.

closes: #8626
https://pulp.plan.io/issues/8626
@goosemania goosemania merged commit 3462b2c into pulp:master Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants