Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to build Vagrant boxes for Pulp 3 #467

Closed
wants to merge 1 commit into from

Conversation

ammaritiz
Copy link

@ammaritiz ammaritiz commented Jan 10, 2018

Add a new job called "pulp-3-build-box", which
builds Vagrant boxes on an arbitrary host, over SSH,
using Packer and Ansible. Also, uploads them to
Vagrant cloud with box-name "pulp/pulpcore"
for community usage.

  • update welcome message using motd

closes #2908

},
{
"type": "vagrant-cloud",
"access_token": "0v2o8xCp8Ynnfg.atlasv1.RMc1BFNzAsRiyhMN5mgByb2CtSVkzo1AYZM28SWmJaTqZ2yjf0GG2aGkftqwh1ySEPs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this token from here. it should be stored as a secret in jenkins. you should also revoke it and generate a new one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new token in Jenkins and modified the scripts to use this token for uploading boxes.

@ammaritiz ammaritiz force-pushed the pulp3box-2908 branch 2 times, most recently from bbd6f04 to eb77e34 Compare January 13, 2018 13:59
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I really like this. I left a couple of comments. I think it would be good if we could break this out into 2 jobs. 1 that prepares the environment with all the right packages and another that does the box builds. The job that prepares the environment should only be manually triggered.

- name: Install ansible galaxy roles
command: ansible-galaxy install -r requirements.yml

- name: Reboot Server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reboot actually needed here?

Copy link
Author

@ammaritiz ammaritiz Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this, because at the end of a build, both VirtualBox and KVM are running, hence, on the next build, KVM build fails saying "Device or Resource is busy". This is because, KVM can't take advantage of virtualization, while VirtualBox is running.

when: (libvirt.status.ActiveState != 'active') or
(libvirt.status.LoadState != 'loaded')

- name: Add F26 virtualbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/virtualbox/libvirt box/

@ammaritiz ammaritiz force-pushed the pulp3box-2908 branch 7 times, most recently from cf25a9e to d80d88a Compare January 26, 2018 14:52
@ammaritiz
Copy link
Author

Back at you @dkliban . I'll add the docs in a different PR.

@ammaritiz ammaritiz force-pushed the pulp3box-2908 branch 6 times, most recently from c51bfe1 to 7cd3e0b Compare February 7, 2018 16:25
@dralley
Copy link
Collaborator

dralley commented Mar 7, 2018

Add a link to the Redmine issue at the bottom of the commit message

Add a new job called "pulp-3-build-box", which
builds Vagrant boxes on an arbitrary host, over SSH,
using Packer and Ansible. Also, uploads them to
Vagrant cloud with box-name "pulp/pulpcore"
for community usage.

closes #2908
https://pulp.plan.io/issues/2908
@dkliban
Copy link
Member

dkliban commented May 14, 2018

We are going to put this effort on hold.

@dkliban dkliban closed this May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants