Uninstall pulp_docker rpms #539
Conversation
The job builder should install these packages from source rather than from an rpm. https://pulp.plan.io/issues/3744 fixes: #3744
ci/jjb/README.md
Outdated
| import ssl | ||
| context = ssl._create_unverified_context() | ||
| response = urlopen(req, context=context, timeout=self.timeout).read() | ||
| (jjb) [vagrant@pulp3 pulp-ci]$ sed -n 522,530p ~/.virtualenvs/jjb/lib/python2.7/site-packages/jenkins/__init__.py |
There was a problem hiding this comment.
This ain't Python code! Maybe change the ```python above to ```console?
| - python-jenkins==0.4.16 | ||
| - jenkins-job-builder==2.0.2 | ||
| - jenkins-job-builder==2.0.9 | ||
| - python-jenkins==1.0.1 |
There was a problem hiding this comment.
Is it correct to say that you've performed an end-to-end test by communicating with Jenkins? We've experienced an issue where the default packages pulled in by pip will let jenkins-jobs test jobs succeed, but not jenkins-jobs update jobs.
There was a problem hiding this comment.
Yup, I ran the update to test the changes.
|
This PR now does much more than uninstalling pulp_docker RPMs. Is there an over-arching theme to these changes? Or are the four commits in this PR separate, and bundled together for the author's convenience? |
|
@Ichimonji10, I've just been fixing the tests and doc builders, discovering new issues as I went. The over-arching theme is I wanted my checks to pass for pulp/pulp_docker#235, but they really are separate changes. |
asmacdo
force-pushed
the
uninstall-rpm-docker
branch
from
c6fcae8
to
e2066dc
Compare
Also adds pip install step to the output to simplify future debugging.
asmacdo
force-pushed
the
uninstall-rpm-docker
branch
from
e2066dc
to
0032195
Compare
The job builder should install these packages from source rather than
from an rpm.
https://pulp.plan.io/issues/3744
fixes: #3744