Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for ordering fails when run against pulpcore 3.16 and 3.18 #569

Closed
dkliban opened this issue Oct 13, 2022 · 0 comments · Fixed by #570
Closed

test for ordering fails when run against pulpcore 3.16 and 3.18 #569

dkliban opened this issue Oct 13, 2022 · 0 comments · Fixed by #570
Assignees
@dkliban
Labels
prio-list driving Pulp's Kanban searches
Milestone
0.16.0

Comments

@dkliban
Copy link
Member

dkliban commented Oct 13, 2022

The functional tests on pulpcore 3.16 and 3.18 branches leave a repository in the system. As a result the ordering test fails.

https://github.com/pulp/pulp-cli/blob/main/tests/scripts/pulpcore/test_query_params.sh#L23
@dkliban dkliban added bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg prio-list driving Pulp's Kanban searches and removed bug Something isn't working (template-set) Triage-Needed Needs to be reviewed at next pulp-cli mtg labels Oct 13, 2022
dkliban added a commit to dkliban/pulp-cli that referenced this issue Oct 13, 2022
@dkliban
Cleans up repositories before executing the ordering test
6885e39 
fixes: pulp#569
@dkliban dkliban mentioned this issue Oct 13, 2022
Merged
dkliban added a commit to dkliban/pulp-cli that referenced this issue Oct 13, 2022
@dkliban
Cleans up repositories before executing the ordering test
9e64092 
fixes: pulp#569
dkliban added a commit to dkliban/pulp-cli that referenced this issue Oct 13, 2022
@dkliban
Checks if the list of repositories is sorted in reverse alphabetical …
c252c19 
…order

Instead of comparing a list of repositories, just checks if the list is in
a reverse alphabetical order.

fixes: pulp#569
dkliban added a commit to dkliban/pulp-cli that referenced this issue Oct 13, 2022
@dkliban
Checks if the list of repositories is sorted in reverse alphabetical …
10c868e 
…order

Instead of comparing a list of repositories, just checks if the list is in
a reverse alphabetical order.

Also added a check for sorting in alphabetical order.

fixes: pulp#569
dkliban added a commit to dkliban/pulp-cli that referenced this issue Oct 13, 2022
@dkliban
Checks if the list of repositories is sorted in reverse alphabetical …
b65dad0 
…order

Instead of comparing a list of repositories, just checks if the list is in
a reverse alphabetical order.

Also added a check for sorting in alphabetical order.

fixes: pulp#569
mdellweg pushed a commit that referenced this issue Oct 13, 2022
@dkliban @mdellweg
Checks if the list of repositories is sorted in reverse alphabetical …
7aa70a4 
…order

Instead of comparing a list of repositories, just checks if the list is in
a reverse alphabetical order.

Also added a check for sorting in alphabetical order.

fixes: #569
@mdellweg mdellweg added this to the 0.16.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkliban dkliban

Labels
prio-list driving Pulp's Kanban searches
Projects
RH Pulp Kanban board
Archived in project
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Checks if the list of repositories is sorted in reverse alphabetical order dkliban/pulp-cli
2 participants
@dkliban @mdellweg