rpm 'gpgcheck', 'repo_gpgcheck' is expected to be an integer.

[tjmullicani]

Summary

When running pulp rpm repository create or pulp rpm repository update with --gpgcheck or --repo-gpgcheck, I get the error below.

Steps to reproduce

$ pulp rpm repository update --name yum-docker-el7 --remote yum-docker-el7 --gpgcheck 1 --repo-gpgcheck 1
Error: Validation failed for 'repositories_rpm_rpm_partial_update':
  application/json: 'gpgcheck' is expected to be an integer.
  application/x-www-form-urlencoded: 'gpgcheck' is expected to be an integer.
  multipart/form-data: 'gpgcheck' is expected to be an integer.

Expected behavior

Action to complete successfully.

Stacktrace/Error log

Pulp and pulp-cli version info

pulp-ansible 0.16.1
pulp-cli 0.18.0
pulp-cli-deb 0.0.4
pulp-container 2.14.3
pulp-deb 2.20.1
pulp-file 1.12.0
pulp-glue 0.18.0
pulp-python 3.8.0
pulp-rpm 3.19.1
pulpcore 3.22.3

Additonal context

Setting the click.option for gpgcheck and repo-gpgcheck to type int seems to fix, but I'm not sure that's the right answer.

pulp-cli/pulpcore/cli/rpm/repository.py

Line 134 in 2cc6dc4

click.option("--gpgcheck", type=click.Choice(("0", "1"))),

update_options = [
...
  click.option("--gpgcheck", type=int),
  click.option("--repo-gpgcheck", type=int),
...
]

[ggainey]

Given that a .repo file wants this to be 0 or 1, and the REST API wants 0 or 1, and the database wants 0 or 1, I think making this type=int is exactly the right answer. We could make it a flag, and then have the CLI convert it to 0/1 on the way up to the REST call - but the "consistency" argument wins for me.

[stevebleazard]

This also applies to --gpgcheck. After a bit of testing I came up with
...
click.option("--gpgcheck", type=click.IntRange(0,1)),
click.option("--repo-gpgcheck", type=click.IntRange(0,1)),
...
This will restrict the values to 0 and 1

[MichalPysik]

@stevebleazard 's solution obviously no longer prints [0|1] in help text (it prints 'INTEGER RANGE' instead), which was quite useful, but it still prints [0<=x<=1], which is the same information, just in a bit uglier format sadly.

I'm opening a bugfix, but maybe we may want to do something like a callback that transforms CHOICE to INT, just for the prettier help text.