Add container build image commands #504
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
container-build
branch
from
866f571
to
ef3750e
Compare
mdellweg
reviewed
Jul 30, 2022
pulpcore/cli/container/context.py
Outdated
| tag: Optional[str], | ||
| artifacts: Optional[str], | ||
| ) -> Any: | ||
| body = {"containerfile_artifact": container_artifact, "tag": tag, "artifacts": artifacts} |
There was a problem hiding this comment.
I think, i would add a needs_capability here.
pulpcore/cli/container/context.py
Outdated
| @@ -153,6 +164,10 @@ class PulpContainerPushRepositoryContext(PulpContainerBaseRepositoryContext): | |||
| "roles": [PluginRequirement("container", "2.11.0")], | |||
| } | |||
|
|
|||
| def remove_image(self, digest: str) -> Any: | |||
| body = {"digest": digest} | |||
|
@gerrod3, are you able to continue working on this PR? We fixed the issues with the builder on the plugin's side (pulp/pulp_container@a6c2103). |
Yes, I can resume work on it now. |
gerrod3
force-pushed
the
container-build
branch
from
0c713c8
to
7cb86cc
Compare
mdellweg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #424
TODO: