Add global repository version list command #647
Conversation
| if self.repository_ctx.tangible: | ||
| return {self.repository_ctx.HREF: self.repository_ctx.pulp_href} | ||
| else: | ||
| return {} |
There was a problem hiding this comment.
Now i need to find a new way to make the existence of lookup values in the repository context mandatory for version detail commands. XD
There was a problem hiding this comment.
When does scope get called? You could add more logic to the version generic command that checks list_only and sets a parameter on the context object which scope could check to make sure the lookup has been set.
There was a problem hiding this comment.
Yeah, something like that.
There was a problem hiding this comment.
It sounds easier to not use the baseclass RepositoryContext for the generic endpoint, but subclass one for it. I will keep the tangible however. I like it.
mdellweg
force-pushed
the
repo_ver_list
branch
3 times, most recently
from
47c8a1e
to
c637cb8
Compare
mdellweg
changed the title
mdellweg
force-pushed
the
repo_ver_list
branch
3 times, most recently
from
66bdb2e
to
2552089
Compare
| if self.has_plugin(PluginRequirement("core", max="99.99.0")): | ||
| # https://github.com/pulp/pulpcore/issues/3634 | ||
| for operation_id, (method, path) in self.api.operations.items(): |
There was a problem hiding this comment.
You think we should look into moving this method into it's own file? context.py will grow quite large as we discover more schema bugs. Also, can plugins that are not apart of this package contribute to this method?
There was a problem hiding this comment.
No, they cannot, and that is a valid concern. Maybe we need some plugin lookup for glue parts after all.
| ) -> None: | ||
| result = repository_version_ctx.repair() | ||
| pulp_ctx.output_result(result) | ||
| callback.add_command(list_command(decorators=decorators + [content_in_option])) |
There was a problem hiding this comment.
This is also adding the --content fields to all of the other plugin repo version commands too, neat.
fixes #631
Review Checklist: