Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to pulp-glue #809

Merged
merged 1 commit into from Oct 4, 2023
Merged

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Oct 4, 2023

fixes #634

Review Checklist:

  • An issue is properly linked. [feature and bugfix only]
  • Tests are present or not feasible.
  • Commits are split in a logical way (not historically).

@mdellweg mdellweg marked this pull request as ready for review October 4, 2023 07:41
@mdellweg mdellweg requested a review from gerrod3 October 4, 2023 08:23
@mdellweg mdellweg enabled auto-merge (rebase) October 4, 2023 13:57
@gerrod3
Copy link
Contributor

gerrod3 commented Oct 4, 2023

What is the difference between .pot and .po files? Also, do you plan to add more translations to the message strings?

@mdellweg
Copy link
Member Author

mdellweg commented Oct 4, 2023

If po stands for "i don't know what", pot is "template for i don't know what".

I think, you extract the strings into the template, multtiply the template into all the languages as po files, and add the translations there. Then you compile them into mo files and ship those with the binaries.

No I don't intend to do any more translations now.

@mdellweg mdellweg merged commit fe19d8e into pulp:main Oct 4, 2023
13 checks passed
@mdellweg mdellweg deleted the 634_update_i18n branch October 5, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[task] make the i18n features work with the glue lib
2 participants