Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a valid debian repo containing no packages #187

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add a valid debian repo containing no packages #187

merged 1 commit into from
Aug 12, 2020

Conversation

quba42
Copy link
Collaborator

@quba42 quba42 commented Aug 12, 2020

Fixture needed for a test driven approach to solving https://pulp.plan.io/issues/6920

mdellweg
mdellweg reviewed Aug 12, 2020
View reviewed changes
debian/conf/distributions
@@ -10,3 +10,9 @@ Description: This is a valid Debian repository.
Architectures: ppc64
Components: asgard
SignWith: 6EDF301256480B9B801EBA3D05A5E6DA269D9D98

codename: ginnungagap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@quba42
Copy link
Collaborator Author

quba42 commented Aug 12, 2020

I ran the pulp_deb tests against a locally built container with this change.
I had four failed tests, however those also failed with a locally built container without this change, so it is probably something to do with my environment and not with the change (all tests have been passing on recent pulp_deb PRs).

The failed tests were all in:

django-admin test pulp_deb.tests.functional.api.test_download_policies

I am nevertheless removing the "Draft" status.

@quba42 quba42 marked this pull request as ready for review August 12, 2020 13:37
mdellweg
mdellweg approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know of reprepro export but this looks good to me.

@quba42 quba42 merged commit 105527a into pulp:master Aug 12, 2020
@quba42 quba42 deleted the empty_deb_repo branch August 12, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quba42 @mdellweg