Prepare fixtures container for Openshift #208
Conversation
|
These code changes look good to me. We link commits to our issue tracker but you can get around this by adding |
Curious, it work on openshift. That's a bit annoying, I will need to find a way. |
|
I am doing some test by using a Fedora base image, and chasing down the UBI issue (because UBI usage is on the plate of my boss). I have read the doc, it doesn't say you need a subscription: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/building_running_and_managing_containers/index#using_standard_red_hat_base_images And running: seems to work fine on my Fedora 33 Silverblue laptop, and I never entered any credentials. I guess the difference is maybe podman vs docker (and how the registry is accessed), and the credentials message is misleading. |
mscherer
force-pushed
the
fix_fixtures
branch
3 times, most recently
from
ef52593
to
176d696
Compare
|
Ok so the problem with the container was registry.redhat.io vs registry.access.redhat.com. I guess I used a old doc somewhere. |
This permit to build the new container in openshift, and then run it in 2 steps. When building the image in Openshift, the BASE_URL variable can be defined at build time (in the BuildConfig object), and so will run sed, but not nginx. Then at deployment time, the URL having been set already, we do not change anything. [noissue]
mscherer
force-pushed
the
fix_fixtures
branch
from
e45d0eb
to
fa18863
Compare
|
This looks good to me. Just out of curiosity: why change the port from 80 to 8080? |
|
Ah, I see the answer in one of your commits. Thanks! This is still a draft. Feel free to unset that when you think it's ready and I can merge. |
The nginx upstream image have issues, either by not running in Openshift, or being too restricted to change the directory. We also have to listen on port 8080, since Openshift will not let nginx start on port 80. [noissue]
mscherer
force-pushed
the
fix_fixtures
branch
from
fa18863
to
8125ab2
Compare
|
So, i was waiting on more info from openshift PM, but got no answer, so I will proceed with my plan for https. I guess I shouldn't have blocked the merge on that :/ |
So this commit prepare for a migration of fixtures to openshift.
I just need to take a look at the https deployment, there is a operator for that. And do the job.