Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove k8s.io/kubernetes as a dependency #1192

Closed
git-hyagi opened this issue Jan 17, 2024 · 0 comments · Fixed by #1193
Closed

Remove k8s.io/kubernetes as a dependency #1192

git-hyagi opened this issue Jan 17, 2024 · 0 comments · Fixed by #1193
Labels
Feature

Comments

@git-hyagi
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As of now, we are importing k8s.io/kubernetes just to use the hash function from it, but from kubernetes/kubernetes#79384 it seems like it is not recommended to use this package.

Describe the solution you'd like
To avoid issues with package dependencies, we should use another way to calculate the hash.

note: big thanks to @cognifloyd for identifying this
cognifloyd added a commit to cognifloyd/pulp-operator that referenced this issue Jan 17, 2024
@cognifloyd
drop dependency on k8s.io/kubernetes
5d0df3b 
fixes pulp#1192
cognifloyd added a commit to cognifloyd/pulp-operator that referenced this issue Jan 17, 2024
@cognifloyd
drop dependency on k8s.io/kubernetes
c7aa2dd 
fixes pulp#1192
@cognifloyd cognifloyd mentioned this issue Jan 17, 2024
Merged
openshift-merge-bot bot pushed a commit that referenced this issue Jan 18, 2024
@cognifloyd @openshift-merge-bot
drop dependency on k8s.io/kubernetes
e508741 
fixes #1192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove k8s.io/kubernetes dependency cognifloyd/pulp-operator
1 participant
@git-hyagi