Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Investigate if "common" ingress configs are right #923

Closed
git-hyagi opened this issue Mar 30, 2023 · 0 comments · Fixed by #1009
Closed

[TASK] Investigate if "common" ingress configs are right #923

git-hyagi opened this issue Mar 30, 2023 · 0 comments · Fixed by #1009
Labels

Comments

@git-hyagi
Copy link
Collaborator

For ingresses deployed with non nginx controllers nor openshift-default classes the rules seem to be "wrong". For such cases, the ingresses should be created with a single rule configured with pulp-web as the backend, but they are getting created like:

  rules:
  - host: test.com
	http:
  	paths:
  	- backend:
      	service:
        	name: example-pulp-content-svc
        	port:
          	name: content-24816
    	path: /pulp/content/
    	pathType: Prefix
  	- backend:
      	service:
        	name: example-pulp-api-svc
        	port:
          	name: api-24817
    	path: /pulp/api/v3/
    	pathType: Prefix
  	- backend:
      	service:
        	name: example-pulp-api-svc
        	port:
          	name: api-24817
    	path: /auth/login/
    	pathType: Prefix
  	- backend:
      	service:
        	name: example-pulp-api-svc
        	port:
          	name: api-24817
    	path: /
    	pathType: Prefix
  	- backend:
      	service:
        	name: example-pulp-web-svc
        	port:
          	number: 24880
    	path: /
    	pathType: Prefix
git-hyagi added a commit to git-hyagi/pulp-operator that referenced this issue Jul 18, 2023
After a discussion, the team decided that would be better
to remove the ingress class checks and also automatically
collecting the default ingress domain because they would
need cluster roles.
fixes pulp#885
fixes pulp#917
fixes pulp#918
fixes pulp#923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant