Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Content Unit deletion tests, and replace the delete Content Unit operations with orphan cleanup #926

Closed
dralley opened this issue Apr 4, 2018 · 2 comments
Closed

Remove Content Unit deletion tests, and replace the delete Content Unit operations with orphan cleanup #926

dralley opened this issue Apr 4, 2018 · 2 comments
Labels
Pulp Version: 3

Comments

@dralley
Copy link
Contributor

dralley commented Apr 4, 2018 •
edited
Loading

Pulp Issue #3445 (https://pulp.plan.io/issues/3445) removed the ability to delete content units, because it's inherently racy. Content Units could be deleted while a using them is still running.

Therefore plugin tests (currently the file plugin) which test Content Unit CRUD are currently broken. The Content Unit tests that test deletion should be removed, and the "tear down" routine should use orphan cleanup - once that functionality is completed (PR open to do so currently).
@dralley
Copy link
Contributor Author

dralley commented Apr 5, 2018

Orphan cleanup PR is merged - this issue is now unblocked

@dralley
Copy link
Contributor Author

dralley commented Apr 5, 2018

Related to: #914

nixocio pushed a commit to nixocio/pulp-smash that referenced this issue Apr 6, 2018
Remove delete content units.
082ef3e 
In order to avoid a race condition it was removed the feature to remove
content units.

See: https://pulp.plan.io/issues/3445

A new endpoint was added `/api/v3/orphans/` and using the
DELETE method and this endpoint all orphan content units will be
removed. This endpoint also removes orphan artifact units.

Adjust pulp-smash to this new scenario.

Remove:
 * clean_content_units
 * clean_artifacts

Add:
 * delete_orphan_units

Closes:pulp#926

Related:pulp#914
@nixocio nixocio mentioned this issue Apr 6, 2018
Merged
nixocio pushed a commit to nixocio/pulp-smash that referenced this issue Apr 6, 2018
Remove delete content units.
3f9ec19 
In order to avoid a race condition it was removed the feature to remove
content units.

See: https://pulp.plan.io/issues/3445

A new endpoint was added `/api/v3/orphans/` and using the
DELETE method and this endpoint all orphan content units will be
removed. This endpoint also removes orphan artifact units.

Adjust pulp-smash to this new scenario.

Remove:
 * clean_content_units
 * clean_artifacts

Add:
 * delete_orphan_units

Closes:pulp#926

Related:pulp#914
Ichimonji10 pushed a commit that referenced this issue Apr 6, 2018
@Ichimonji10
Remove delete content units.
92014a3 
In order to avoid a race condition it was removed the feature to remove
content units.

See: https://pulp.plan.io/issues/3445

A new endpoint was added `/api/v3/orphans/` and using the
DELETE method and this endpoint all orphan content units will be
removed. This endpoint also removes orphan artifact units.

Adjust pulp-smash to this new scenario.

Remove:
 * clean_content_units
 * clean_artifacts

Add:
 * delete_orphan_units

Closes:#926

Related:#914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pulp Version: 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dralley @nixocio