Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate BaseAPITestCase #1025

Merged
merged 1 commit into from
May 24, 2018
Merged

Deprecate BaseAPITestCase #1025

merged 1 commit into from
May 24, 2018

Conversation

Ichimonji10
Copy link
Contributor

It encourages fragile clean-up logic and slows down tests by
unnecessarily deleting orphans.

nixocio
nixocio approved these changes May 24, 2018
View reviewed changes
Copy link

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to include a link for the documentation related to addCleanup in the WARNING section.

@Ichimonji10
Deprecate BaseAPITestCase
4630bf7 
It encourages fragile clean-up logic and slows down tests by
unnecessarily deleting orphans.
@Ichimonji10
Copy link
Contributor Author

Great idea!

@nixocio nixocio merged commit 4630bf7 into pulp:master May 24, 2018
@Ichimonji10 Ichimonji10 mentioned this pull request May 25, 2018
Closed
@Ichimonji10 Ichimonji10 deleted the deprecate-base branch May 29, 2018 14:55
@rochacbruno rochacbruno mentioned this pull request Sep 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Make Pulp Smash a Framework
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ichimonji10 @nixocio