Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test last_override_config, drop a BaseAPITestCase #1088

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Test last_override_config, drop a BaseAPITestCase #1088

merged 1 commit into from
Jun 28, 2018

Conversation

Ichimonji10
Copy link
Contributor

Rewrite pulp_smash.tests.pulp2.docker.api_v2.test_sync:

  • Drop BaseAPITestCase from the module.
  • Assert that last_override_config is an empty dict.
  • Restructure the tests to be more independent.

See: #763

Fix: #1066

@Ichimonji10
Copy link
Contributor Author

Tested against Pulp 2.16.2 beta on F26, F27, and RHEL 7.

@Ichimonji10
Test last_override_config, drop a BaseAPITestCase
c7e94c0 
Rewrite `pulp_smash.tests.pulp2.docker.api_v2.test_sync`:

* Drop `BaseAPITestCase` from the module.
* Assert that `last_override_config` is an empty dict.
* Restructure the tests to be more independent.

See: #763

Fix: #1066
@Ichimonji10 Ichimonji10 merged commit c7e94c0 into pulp:master Jun 28, 2018
@Ichimonji10 Ichimonji10 deleted the docker-test-sync branch June 28, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ichimonji10 @rochacbruno