Update Pulp 3 utils to use absolute URL #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulp 3 is adjusting the use of relative URLs, adjust utils functions accordingly. https://pulp.plan.io/issues/5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Oct 31, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 https://pulp.plan.io/issues/5629 re pulp#5629
This was referenced Oct 31, 2019
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Oct 31, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
|
@bmbouter, just let me know when this change should be merged. |
|
@kersommoura will do. I think it's going to be monday. I'm preparing a few other PRs that need to be in place before we merge. I'll let you know when they are ready. |
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Nov 4, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
mikedep333
pushed a commit
to mikedep333/pulp_file
that referenced
this pull request
Nov 5, 2019
This is based on the following commit: Set CONTENT_ORIGIN settings The Travis environment needs `content_origin` set as a setting. This also updates the tests to expect Pulp's Distribution.base_url to provide absolute urls. Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 https://pulp.plan.io/issues/5629
mikedep333
pushed a commit
to mikedep333/pulp_file
that referenced
this pull request
Nov 5, 2019
This is based on the following commit: Set CONTENT_ORIGIN settings The Travis environment needs `content_origin` set as a setting. This also updates the tests to expect Pulp's Distribution.base_url to provide absolute urls. Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 https://pulp.plan.io/issues/5629 [noissue]
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Nov 7, 2019
Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 [noissue]
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Nov 7, 2019
Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 [noissue]
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Nov 8, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re pulp#5629
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Nov 8, 2019
ref #5629 Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Nov 8, 2019
daviddavis
pushed a commit
to daviddavis/pulp_ansible
that referenced
this pull request
Nov 8, 2019
pulpcore changed the setting name from CONTENT_HOST to CONTENT_ORIGIN. Required PR: pulp/pulpcore#370 Required PR: pulp/pulp-smash#1227 https://pulp.plan.io/issues/5629 re #5629
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Nov 8, 2019
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Nov 8, 2019
fixes pulp#5649 https://pulp.plan.io/issues/5649 Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_file#308
ipanova
added a commit
to pulp/pulp_container
that referenced
this pull request
Nov 8, 2019
Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 closes #4417 https://pulp.plan.io/issues/4417
ipanova
added a commit
to pulp/pulp_container
that referenced
this pull request
Nov 8, 2019
Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 closes #4417 https://pulp.plan.io/issues/4417
daviddavis
pushed a commit
to pulp/pulpcore
that referenced
this pull request
Nov 8, 2019
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user. Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 Required PR: pulp/pulp_file#303 https://pulp.plan.io/issues/5629 re #5629
daviddavis
pushed a commit
to pulp/pulpcore
that referenced
this pull request
Nov 8, 2019
fixes #5649 https://pulp.plan.io/issues/5649 Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_file#308
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Nov 8, 2019
The Travis environment needs `content_origin` set as a setting. This also updates the tests to expect Pulp's Distribution.base_url to provide absolute urls. Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 Required PR: pulp/pulp_installer#185 https://pulp.plan.io/issues/5629 re #5629
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Nov 8, 2019
ref #5629 Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227
ipanova
added a commit
to pulp/pulp_container
that referenced
this pull request
Nov 8, 2019
Required PR: pulp/pulpcore#358 Required PR: pulp/pulp-smash#1227 closes #4417 https://pulp.plan.io/issues/4417
daviddavis
pushed a commit
to pulp/pulp_ansible
that referenced
this pull request
Nov 8, 2019
pulpcore changed the setting name from CONTENT_HOST to CONTENT_ORIGIN. Required PR: pulp/pulpcore#370 Required PR: pulp/pulp-smash#1227 https://pulp.plan.io/issues/5629 re #5629
ipanova
added a commit
to pulp/pulp_container
that referenced
this pull request
Nov 8, 2019
Required PR: pulp/pulp-smash#1227 closes #4417 https://pulp.plan.io/issues/4417
|
@kersommoura changes in core have been merged, please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulp 3 is adjusting the use of relative URLs, adjust utils functions
accordingly.
https://pulp.plan.io/issues/5629