Makes pulp_smash a pytest plugin #1262

bmbouter · 2021-12-07T20:46:06Z

This provides a common place for any pytest fixtures to be added.

mdellweg · 2021-12-08T09:25:47Z

pulp_smash/pulp3/pytest_plugin/__init__.py

+
+
+@pytest.fixture
+def async_monitor_task(tasks_api_client):


I still fail to see the value in this being a "fixture".

I agree. I'm not finished with this one yet. The issue I'm struggling with is that if this becomes a normal function then I can't access the chain of fixtures it depends on tasks_api_client -> pulpcore client fixtures. I'm going to look at this more today.

Oh right. There is a point.

mdellweg · 2021-12-08T09:26:19Z

pulp_smash/pulp3/pytest_plugin/__init__.py

+
+@pytest.fixture
+def tasks_api_client(pulpcore_client):
+    return TasksApi(pulpcore_client)


I pretty much like this. Can we mark it as scope="session"?

I think this was a very good idea.

Required PR: pulp/pulp-smash#1262

Required PR: pulp/pulp-smash#1262 closes #9623

pulp_smash/pulp3/pytest_plugin/__init__.py

Required PR: pulp/pulp-smash#1262 closes #9623

pulp_smash/pulp3/pytest_plugin/__init__.py

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter · 2021-12-16T16:00:04Z

pulp_smash/pulp3/pytest_plugin/__init__.py

+@pytest.fixture
+def delete_orphans_post():
+    yield
+    delete_orphans()
+
+
+@pytest.fixture
+def delete_orphans_pre_post(delete_orphans_pre, delete_orphans_post):
+    yield


I kind of think we should delete these two, and have everyone use delete_orphans_pre. Doing it both before and after for each test is a lot and will slow us down. Additionally, I'm not even sure the post will free up actual orphans due to the run order. After the test finishes and it's tearing down all of the fixtures, if the delete_orphans_post runs before the deletion of the repository itself, it won't even free the orphans. Rather than worry about fixing that, let's just use delete_orphans_pre. @mdellweg wdyt?

sounds good. We could depend other fixtures on this one to get the order right.
(cleanup is in reverse dependency order.)

Agreed. I made this change and the runtime dropped by a few more seconds for the 7 tests I've been running. It also removed one unecessary fixture in the other PR too.

Required PR: pulp/pulp-smash#1262 closes #9623

mdellweg

I don't think, we need the conftest.py in this repo. But probably does not hurt also.

pulp_smash/pulp3/pytest_plugin/__init__.py

bmbouter · 2021-12-17T15:07:15Z

pulp_smash/pulp3/pytest_plugin/__init__.py

+
+
+@pytest.fixture
+def gen_object_with_cleanup():


Maybe gen_objects_with_cleanup_async_delete ?

I would do autodetection whether there is waiting on tasks needed.

This provides a common place for any pytest fixtures to be added.

Required PR: pulp/pulp-smash#1262 closes #9623

dralley · 2021-12-20T15:05:09Z

pulp_smash/pulp3/pytest_plugin/__init__.py

+import socket
+import ssl
+
+from dataclasses import dataclass


This breaks compatibility with Python 3.6

Hmmm, maybe I need to rework this so it doesn't break old release branches....

This got addressed a04c4ee

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 19759b5 to 01c1ff4 Compare December 7, 2021 23:07

bmbouter marked this pull request as draft December 7, 2021 23:07

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 7, 2021

Adds a pytest local fixture for pulp_file

68313f3

Required PR: pulp/pulp-smash#1262

bmbouter mentioned this pull request Dec 7, 2021

Adds a pytest local fixture for pulp_file pulp/pulpcore#1728

Merged

mdellweg reviewed Dec 8, 2021

View reviewed changes

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch 2 times, most recently from d1ea780 to dee2a3c Compare December 8, 2021 20:25

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

e5dc934

Required PR: pulp/pulp-smash#1262

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

8bce463

Required PR: pulp/pulp-smash#1262

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from dee2a3c to ea9039a Compare December 8, 2021 20:51

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

6896b5e

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

d99a9f3

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

0ad113c

Required PR: pulp/pulp-smash#1262 closes #9623

mdellweg reviewed Dec 8, 2021

View reviewed changes

pulp_smash/pulp3/pytest_plugin/__init__.py Outdated Show resolved Hide resolved

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

12b6ea4

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch 2 times, most recently from 008569f to 6ce1ec5 Compare December 8, 2021 21:38

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

71a9a59

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 8, 2021

Adds a pytest local fixture for pulp_file

3163ec8

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 6ce1ec5 to b516e90 Compare December 8, 2021 22:00

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 9, 2021

Adds a pytest local fixture for pulp_file

f6330c3

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 9, 2021

Adds a pytest local fixture for pulp_file

e0e642a

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 9, 2021

Adds a pytest local fixture for pulp_file

c6bdf81

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 9, 2021

Adds a pytest local fixture for pulp_file

5f4b3d4

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 10, 2021

Adds a pytest local fixture for pulp_file

e1d1b2b

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from b516e90 to cd77852 Compare December 10, 2021 17:22

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 10, 2021

Adds a pytest local fixture for pulp_file

531f9a8

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 10, 2021

Adds a pytest local fixture for pulp_file

806e460

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from cd77852 to a0e2657 Compare December 10, 2021 17:40

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

18e5a3d

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from bc72bbd to 87d4427 Compare December 15, 2021 19:56

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

e81e707

Required PR: pulp/pulp-smash#1262 closes #9623

mdellweg reviewed Dec 15, 2021

View reviewed changes

pulp_smash/pulp3/pytest_plugin/__init__.py Outdated Show resolved Hide resolved

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

c0ef1ba

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch 2 times, most recently from 48137c9 to 724376e Compare December 15, 2021 21:03

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

9fac68f

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

77c7e5c

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 724376e to 8faee76 Compare December 15, 2021 21:07

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

4121832

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 15, 2021

Adds a pytest local fixture for pulp_file

e460884

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 16, 2021

Adds a pytest local fixture for pulp_file

5a301da

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter commented Dec 16, 2021

View reviewed changes

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 8faee76 to 2234680 Compare December 16, 2021 16:18

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 16, 2021

Adds a pytest local fixture for pulp_file

1f79215

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 16, 2021

Adds a pytest local fixture for pulp_file

49116f2

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 16, 2021

Adds a pytest local fixture for pulp_file

33e8a72

Required PR: pulp/pulp-smash#1262 closes #9623

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Dec 16, 2021

Adds a pytest local fixture for pulp_file

5dfb7d1

Required PR: pulp/pulp-smash#1262 closes #9623

mdellweg reviewed Dec 17, 2021

View reviewed changes

bmbouter commented Dec 17, 2021

View reviewed changes

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 2234680 to 2a157d2 Compare December 17, 2021 15:11

Makes pulp_smash a pytest plugin

c797c74

This provides a common place for any pytest fixtures to be added.

bmbouter force-pushed the add-pytest-plugin-with-aiohttp-fixutres branch from 2a157d2 to c797c74 Compare December 17, 2021 15:56

mdellweg approved these changes Dec 17, 2021

View reviewed changes

dkliban approved these changes Dec 17, 2021

View reviewed changes

bmbouter merged commit 677f50e into pulp:main Dec 17, 2021

bmbouter deleted the add-pytest-plugin-with-aiohttp-fixutres branch December 17, 2021 16:57

bmbouter added a commit to pulp/pulpcore that referenced this pull request Dec 17, 2021

Adds a pytest local fixture for pulp_file

70b7f31

Required PR: pulp/pulp-smash#1262 closes #9623

dralley reviewed Dec 20, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Makes pulp_smash a pytest plugin #1262

Makes pulp_smash a pytest plugin #1262

bmbouter commented Dec 7, 2021

mdellweg Dec 8, 2021

bmbouter Dec 8, 2021

mdellweg Dec 8, 2021

mdellweg Dec 8, 2021

bmbouter Dec 8, 2021

bmbouter Dec 16, 2021

mdellweg Dec 16, 2021

bmbouter Dec 16, 2021

mdellweg left a comment

bmbouter Dec 17, 2021

mdellweg Dec 17, 2021

dralley Dec 20, 2021

bmbouter Jan 4, 2022

bmbouter Jan 14, 2022



		@pytest.fixture
		def async_monitor_task(tasks_api_client):



		@pytest.fixture
		def gen_object_with_cleanup():

Makes pulp_smash a pytest plugin #1262

Makes pulp_smash a pytest plugin #1262

Conversation

bmbouter commented Dec 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdellweg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment