Add tests for CRD artifacts. #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested against F27, with the following versions of Pulp3 packages. pulp-file==0.0.1a15 |
Ichimonji10
reviewed
Feb 27, 2018
| # To avoid duplicates in pulp. This function call may be removed after | ||
| # pulp3 is able to handle duplicates, and how to delete artifacts that | ||
| # are content units as well. | ||
| clean_artifacts() |
Ichimonji10
reviewed
Feb 27, 2018
pulp_smash/tests/pulp3/utils.py
Outdated
| """ | ||
| if cfg is None: | ||
| cfg = config.get_config() | ||
| clean_content_units() |
nixocio
force-pushed
the
p3_test_issue_726
branch
3 times, most recently
from
1b94c2c
to
2218e5c
Compare
|
Please rebase onto master and resolve the merge conflicts. |
As of this writing, pulp3 does not handle upload of duplicate files. Due that, there is a need to clean the artifacts present in pulp3, before attempt to upload a new file to pulp3. However, if a file exists as content unit and as artifact, the file has to be deleted first as a content unit then as an artifact. To solve this issue, 2 new functions were added to pulp3/utils. - `clean_content_units()` - `clean_artifacts()` Add tests to CRD artifacts. 1. Create an artifact by uploading a file to pulp3. 2. Reads an artifact by its href. 3. Delete an artifact. Closes: pulp#726
nixocio
force-pushed
the
p3_test_issue_726
branch
from
2218e5c
to
e8f0fda
Compare
Ichimonji10
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this writing, pulp3 does not handle upload of duplicate files.
Due that, there is a need to clean the artifacts present in pulp3, before
attempt to upload a new file to pulp3.
However, if a file exists as content unit and as artifact, the file has
to be deleted first as a content unit then as an artifact.
To solve this issue, 2 new functions were added to pulp3/utils.
clean_content_units()clean_artifacts()Add tests to CRD artifacts.
Closes: #726