Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible tokens stored in plaintext #1221

Closed
newswangerd opened this issue Sep 1, 2022 · 0 comments · Fixed by #1222
Closed

Ansible tokens stored in plaintext #1221

newswangerd opened this issue Sep 1, 2022 · 0 comments · Fixed by #1222
Assignees
@mdellweg
Labels
Issue prio-list Triage-Needed

Comments

@newswangerd
Copy link
Contributor

The collection remote for pulp_ansible stores tokens in plaintext instead of using pulp's encrypted field (https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/models.py#L234) and exposes them in read/write mode via the API (https://github.com/pulp/pulp_ansible/blob/main/pulp_ansible/app/serializers.py#L170) instead of marking it as write only.
@mdellweg mdellweg self-assigned this Sep 1, 2022
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Sep 1, 2022
@mdellweg
Switch token attribute to be encryped and hidden
5548398 
fixes pulp#1221
@mdellweg mdellweg mentioned this issue Sep 1, 2022
Merged
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Sep 5, 2022
@mdellweg
Switch token attribute to be encryped and hidden
a247bf9 
fixes pulp#1221
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Sep 5, 2022
@mdellweg
Switch token attribute to be encryped and hidden
2763b15 
fixes pulp#1221
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Sep 7, 2022
@mdellweg
Switch token attribute to be encryped and hidden
3572547 
fixes pulp#1221
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Nov 15, 2022
@mdellweg
Switch token attribute to be hidden
550c2a1 
The encryption part was removed from the cherry-pick.

fixes pulp#1221

(cherry picked from commit d13c427)
@mdellweg mdellweg mentioned this issue Nov 15, 2022
Merged
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Nov 16, 2022
@mdellweg
Switch token attribute to be hidden
c0f33d4 
The encryption part was removed from the cherry-pick.

fixes pulp#1221

(cherry picked from commit d13c427)
mdellweg added a commit that referenced this issue Nov 16, 2022
@mdellweg
Switch token attribute to be hidden (#1281)
b4ebeb9 
The encryption part was removed from the cherry-pick.

fixes #1221

(cherry picked from commit d13c427)
patchback bot pushed a commit that referenced this issue Nov 16, 2022
@mdellweg @patchback
Switch token attribute to be hidden (#1281)
8805166 
The encryption part was removed from the cherry-pick.

fixes #1221

(cherry picked from commit d13c427)
(cherry picked from commit b4ebeb9)
@patchback patchback bot mentioned this issue Nov 16, 2022
Merged
mdellweg added a commit that referenced this issue Nov 16, 2022
@patchback @mdellweg
[PR #1281/b4ebeb91 backport][0.10] Switch token attribute to be hidden (
e529f55 
#1286)

**This is a backport of PR #1281 as merged into 0.13
(b4ebeb9).**

The encryption part was removed from the cherry-pick.

fixes #1221

(cherry picked from commit d13c427)

Co-authored-by: Matthias Dellweg <mdellweg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdellweg mdellweg

Labels
Issue prio-list Triage-Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch token attribute to be encryped and hidden mdellweg/pulp_ansible
3 participants
@bmbouter @newswangerd @mdellweg