optimization for x-repo search index builds #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jctanner
force-pushed
the
OPTIMIZE_SEARCH_INDEXING_2023_05_18
branch
from
98b99da
to
8f82ed4
Compare
jctanner
force-pushed
the
OPTIMIZE_SEARCH_INDEXING_2023_05_18
branch
from
8f82ed4
to
4d3eab0
Compare
… version. fixes pulp#1467 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
force-pushed
the
OPTIMIZE_SEARCH_INDEXING_2023_05_18
branch
from
4d3eab0
to
fc590ea
Compare
jctanner
changed the title
mdellweg
approved these changes
May 25, 2023
Comment on lines
+51
to
+52
| if previous_version is None: | ||
| return None |
There was a problem hiding this comment.
Does this mean with retain_repo_versions = 1 there is no optimization?
fixes pulp#1467 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
force-pushed
the
OPTIMIZE_SEARCH_INDEXING_2023_05_18
branch
from
0bb05e2
to
31d0a78
Compare
gerrod3
approved these changes
May 25, 2023
Backport to 0.17: 💚 backport PR created✅ Backport PR branch: Backported as #1469 🤖 @patchback |
gerrod3
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAH-2337
https://issues.redhat.com/browse/AAH-2351
#1467
In the previous iteration of this code, ALL collection indexes would be rebuilt if at least one of their CVs were still in the repository version. This patch uses the .added and .removed functions to make a set of namespace(s).name(s) which have changed in the newest repository version. This set of namespace(s).names(s) can then be used to skip rebuilding the index for a collection which hasn't changed in some way.
Without the patch:
With the patch:
