Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_highest_version when versions were uploaded out-of-order #1624

Merged
merged 1 commit into from Oct 23, 2023

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Oct 20, 2023

fixes: #1623

@jctanner
Copy link
Contributor

@gerrod3 is there more to do before this is merged and released?

@gerrod3 gerrod3 merged commit 55f02c6 into pulp:main Oct 23, 2023
13 checks passed
@patchback
Copy link

patchback bot commented Oct 23, 2023

Backport to 0.20: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.20/55f02c6238176c47f31de7742b5b9264fa4ef73a/pr-1624

Backported as #1625

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 23, 2023
@gerrod3 gerrod3 deleted the is-highest-again branch October 23, 2023 12:53
gerrod3 added a commit that referenced this pull request Oct 23, 2023
gerrod3 added a commit that referenced this pull request Oct 23, 2023
…1624) (#1625)

fixes: #1623
(cherry picked from commit 55f02c6)

Co-authored-by: Gerrod <gerrodubben@gmail.com>
webknjaz added a commit to webknjaz/ansible that referenced this pull request Dec 11, 2023
It updates the underlying `pulp_ansible` to v0.20.2, which fixes a
race condition that is occasiontally observable in our CI when
provisioning the initial dummy collections for testing.

Refs:

  * ansible/galaxy_ng#1950
  * ansible/galaxy#3267
  * pulp/pulp_ansible#1571
  * pulp/pulp_ansible#1572
  * pulp/pulp_ansible#1595
  * pulp/pulp_ansible#1623
  * pulp/pulp_ansible#1624
webknjaz added a commit to webknjaz/ansible that referenced this pull request Dec 11, 2023
It updates the underlying `pulp_ansible` to v0.20.2, which fixes a
race condition that is occasiontally observable in our CI when
provisioning the initial dummy collections for testing.

Refs:

  * https://github.com/ansible/galaxy_ng/releases/tag/4.9.0
  * ansible/galaxy_ng#1950
  * ansible/galaxy#3267
  * pulp/pulp_ansible#1571
  * pulp/pulp_ansible#1572
  * pulp/pulp_ansible#1595
  * pulp/pulp_ansible#1623
  * pulp/pulp_ansible#1624
webknjaz added a commit to webknjaz/ansible that referenced this pull request Dec 11, 2023
It updates the underlying `pulp_ansible` to v0.20.2, which fixes a
race condition that is occasionally observable in our CI when
provisioning the initial dummy collections for testing.

Refs:

  * https://github.com/ansible/galaxy_ng/releases/tag/4.9.0
  * ansible/galaxy_ng#1950
  * ansible/galaxy#3267
  * pulp/pulp_ansible#1571
  * pulp/pulp_ansible#1572
  * pulp/pulp_ansible#1595
  * pulp/pulp_ansible#1623
  * pulp/pulp_ansible#1624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_highest update query can still fail since Django doesn't order the query for Postgres
2 participants