Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary DELETE action for 'set_certified' #247

Merged
merged 1 commit into from Nov 18, 2019

Conversation

romanblanco
Copy link

@romanblanco romanblanco commented Nov 4, 2019

@romanblanco romanblanco changed the title remove unnecessary` DELETE action for 'set_certified' remove unnecessary DELETE action for 'set_certified' Nov 4, 2019
@bmbouter
Copy link
Member

bmbouter commented Nov 8, 2019

@romanblanco Thanks for this! I apologize our contributing docs are not fully up to date. To accept this can you do a few small things?

  1. Can you file a short issue here with the description: https://pulp.plan.io/projects/ansible_plugin/issues/new
  2. Can you include an entry in the CHANGES folder that refers to ^ issue number. See docs here
  3. Can you associate your commit with that issue using this syntax in your commit message.

Thanks again, and I'll try to fix these contributing docs for the future.

@bmbouter
Copy link
Member

bmbouter commented Nov 8, 2019

^ should get the CI passing for you

@romanblanco romanblanco force-pushed the remove-delete-set_certified branch 2 times, most recently from 0f7f424 to d316c71 Compare November 14, 2019 13:06
@romanblanco
Copy link
Author

@bmbouter please, restart Travis.

@bmbouter
Copy link
Member

@romanblanco every time you force push Travis will run. Look at the errors in the job, it's complaining due to black formatting. https://travis-ci.org/pulp/pulp_ansible/jobs/611859747#L440

@bmbouter
Copy link
Member

Currently CI is failing on 'master' so even if this PR is perfect it will still fail. So this work is effectively blocked. :( We're going to fix that other problem, and then post back here when this is unblocked.

@daviddavis daviddavis merged commit c466af3 into pulp:master Nov 18, 2019
@daviddavis
Copy link
Contributor

Thank you @romanblanco!

@romanblanco romanblanco deleted the remove-delete-set_certified branch November 20, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants