Get bindings host from pulp-smash #300
Conversation
| @@ -32,6 +32,7 @@ | |||
|
|
|||
|
|
|||
| configuration = Configuration() | |||
| configuration.host = config.get_config().get_base_url() | |||
| configuration.username = "admin" | |||
There was a problem hiding this comment.
I see the pulp smash config also contains the username and password can this PR also have those configured from the settings too?
If we do that, with multiple configuration points coming from the smash config what about making a new function that will effectively return the fully configured Configuration() object that all bindings could be instantiated with?
What do you think?
There was a problem hiding this comment.
sounds good, I will do that
There was a problem hiding this comment.
@fabricio-aguiar great, I can re-review if you ping me when it's ready.
|
Once the pulp-smash release happens today this will be unblocked to merge. The only thing I want to request is a pulp_ansible specific issue in Redmine and have the changelog refer to that. Would you be willing to do that? |
|
Well that release just happened :) https://pypi.org/project/pulp-smash/1!0.9.0/ |
|
trying to close and reopen to solve travis bug |
https://pulp.plan.io/issues/6339
closes #6339