Renaming version field to name on AnsibleRoleVersion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviddavis This will be a a beta-cycle backwards incompatible change right? I created us a breaking-changes label and tagged this PR with it. I think we should adopt the same release notes approach that we use for core where we just link to the PR changes, release by release using the time-limited URL. I can help put that together if you ack that this is how we want to do it. I plan to test this next week and if it tests well, I'll merge it. |
|
@bmbouter it does introduce a backwards incompatible change which reminds me that I need to update the README. Adding WIP tag. |
|
I think we're redoing the data model in pulp_ansible which makes this change unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3603
https://pulp.plan.io/issues/3603