Reduce amount of time the repository lock is held #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6677 |
alikins
reviewed
Aug 7, 2020
| @@ -195,6 +196,17 @@ def create_collection_from_importer(importer_result): | |||
| return collection_version | |||
|
|
|||
|
|
|||
| def add_collection_to_repository(repository_pk, collection_version_pk): | |||
There was a problem hiding this comment.
This is presumably close enough to the same as https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/tasks/promotion.py#L4
that galaxy_ng should be able to use pulpcore.app.tasks.collections.add_collection_to_repository() once it is merged?
There was a problem hiding this comment.
Yeah that is something we could look at replacing with this
fao89
commented
Aug 10, 2020
Comment on lines
+272
to
+280
| task = instance.task | ||
|
|
||
| completed = ["completed", "failed", "canceled"] | ||
|
|
||
| for child in task.child_tasks.all(): | ||
| if child.state not in completed: | ||
| task.state = child.state | ||
| task.finished_at = child.finished_at | ||
| break |
There was a problem hiding this comment.
@bmbouter this is what I mentioned felt like a hack
|
too old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/6677
closes #6677