Sync collection deprecation status #358
Conversation
|
Attached issue: https://pulp.plan.io/issues/7504 |
|
@fao89 is there any public API that we can sync against that has this data today (for test assertion?) |
| collection, created = Collection.objects.get_or_create( | ||
| namespace=info["namespace"], name=info["name"] | ||
| namespace=info["namespace"], name=info["name"], deprecated=deprecated |
There was a problem hiding this comment.
This code is right, but this _pre_save stage only saves when the unit is created the first time. This means that a situation like
- Pulp sync's a collection and deprecated=False
- time passes and the deprecation flag is marked as True
- This code will never execute to change deprecated=False because the unit is already in Pulp
The issue is that content is immutable in Pulp and this content type is expecting mutability.
There was a problem hiding this comment.
I can do a if..else to check if it is the first time creation
There was a problem hiding this comment.
This issue description is the first problem, it's signalling a deeper issue an if/else won't fix. For example, if we did get it "updating" an existing unit with the deprecated flag once changed, that would be changed for every repository everywhere, which versions are intended to be immutable.
|
closing in favor of: #366 |
https://pulp.plan.io/issues/7504
closes #7504