Adjust distributuon policy. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
commented
May 20, 2021
| "condition": "has_namespace_perms:container.add_containerdistribution", | ||
| }, | ||
| { | ||
| "action": ["create"], |
There was a problem hiding this comment.
allows to create distribution and namespace whenever username matches
ipanova
commented
May 20, 2021
| "condition": "has_namespace_model_perms", | ||
| }, | ||
| { | ||
| "action": ["create"], |
There was a problem hiding this comment.
condition to match when namespace exists
ipanova
commented
May 20, 2021
| @@ -995,7 +995,19 @@ class ContainerDistributionViewSet(DistributionViewSet): | |||
| "action": ["create"], | |||
| "principal": "authenticated", | |||
| "effect": "allow", | |||
| "condition": "has_model_perms:container.add_containerdistribution", | |||
| "condition": "has_namespace_model_perms", | |||
There was a problem hiding this comment.
condition to match when namespace does not exist and does not match the login
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
ipanova
force-pushed
the
wrong-policy
branch
3 times, most recently
from
04e36df
to
5f3d230
Compare
ipanova
force-pushed
the
wrong-policy
branch
2 times, most recently
from
b3d4fab
to
1ac4911
Compare
|
I don't think these changes require a migration, so marking as ready for re-review. |
mdellweg
approved these changes
Jun 28, 2021
goosemania
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noisuse]