Adds a custom lookup value regex for the Manifest viewset. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6884 |
dkliban
force-pushed
the
fix-tag-regex
branch
9 times, most recently
from
a3e89ff
to
634fefa
Compare
ipanova
reviewed
Jun 3, 2020
ipanova
reviewed
Jun 3, 2020
| self.assertTrue(True) | ||
| repository = repositories_api.list(name='foo/bar').results[0] | ||
| distribution = distributions_api.list(name='foo/bar').results[0] | ||
| self.addCleanup(repositories_api.delete, repository.pulp_href) |
There was a problem hiding this comment.
why do we cleanup those resources? subsequent re-pushes should work if repo/distribution is already present
There was a problem hiding this comment.
Tests usually clean up anything they create. This test creates a repository and distribution.
ipanova
reviewed
Jun 3, 2020
ipanova
reviewed
Jun 3, 2020
| @@ -6,8 +6,6 @@ | |||
|
|
|||
| registry = Registry() | |||
|
|
|||
| app.add_routes([web.get('/pulp/container/', registry.serve_v2)]) | |||
| app.add_routes([web.get('/pulp/container/_catalog', registry.list_repositories)]) | |||
There was a problem hiding this comment.
@dkliban i think we can also move tags/list to the urls.py
This fixes a bug where manifest tags could not contain periods. fixes: #6884 https://pulp.plan.io/issues/6884
[noissue]
[noissue]
dkliban
changed the title
ipanova
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where manifest tags could not contain periods.
fixes: #6884
https://pulp.plan.io/issues/6884