Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pulp-smash dependency #796

Closed
hstct opened this issue Jun 9, 2023 · 0 comments · Fixed by #851
Closed

Remove pulp-smash dependency #796

hstct opened this issue Jun 9, 2023 · 0 comments · Fixed by #851
Labels
.misc CHANGES/<issue_number>.misc Tests

Comments

@hstct
Copy link
Contributor

hstct commented Jun 9, 2023

The switch to use local test data instead of the officially hosted ones at https://fixtures.pulpproject.org/ had some unintended side effects. Most tests are using some helper functions in in pulp-smash and they usually default on loading content from the hosted fixtures. This has already caused confusion multiple times during development.

Another reason is that pulp-smash is going to be deprecated at some point: https://discourse.pulpproject.org/t/retirement-of-pulp-smash/579

A lot of functions are already moved to pulpcore as pytest fixture but not everything. So it needs some refactoring.
@hstct hstct added Triage-Needed .misc CHANGES/<issue_number>.misc Tests labels Jun 9, 2023
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 24, 2023
@hstct
Remove pulp-smash from tests
d5f5bb3 
closes pulp#796
@hstct hstct mentioned this issue Jul 24, 2023
Merged
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 24, 2023
@hstct
Remove pulp-smash from tests
f316380 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
11e5435 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
702a72e 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
d2cd27a 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
073e6cc 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
bc175a2 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
ab4e79e 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
3f0644c 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
8186205 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
6d6d796 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
ac1ff3d 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 25, 2023
@hstct
Remove pulp-smash from tests
fc69676 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 26, 2023
@hstct
Remove pulp-smash from tests
e55d747 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 27, 2023
@hstct
Remove pulp-smash from tests
da31265 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 28, 2023
@hstct
Remove pulp-smash from tests
3597f9e 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 28, 2023
@hstct
Remove pulp-smash from tests
d2c8ff5 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 28, 2023
@hstct
Remove pulp-smash from tests
d58126e 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Jul 31, 2023
@hstct
Remove pulp-smash from tests
a3a5ea4 
closes pulp#796
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Aug 7, 2023
@hstct
Remove pulp-smash from tests
f91506f 
closes pulp#796
daviddavis pushed a commit to daviddavis/pulp_deb that referenced this issue Nov 20, 2023
@hstct @daviddavis
Remove pulp-smash from tests
0d54492 
closes pulp#796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.misc CHANGES/<issue_number>.misc Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pulp smash ATIX-AG/pulp_deb
2 participants
@quba42 @hstct