Add retrieve functionality #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This currently does not work, because the UniqueTogetherValidator says no before retrieve is ever called. |
quba42
force-pushed
the
retrieve_functionality
branch
from
850c449
to
dd1b239
Compare
|
Requieres pulp/pulpcore#5084 |
|
The alternative to the pulpcore change appears to be to switch the serializer from |
This was referenced Feb 28, 2024
quba42
force-pushed
the
retrieve_functionality
branch
from
dd1b239
to
f123d1d
Compare
quba42
commented
Feb 28, 2024
quba42
force-pushed
the
retrieve_functionality
branch
2 times, most recently
from
cdfba79
to
359b7b1
Compare
|
I should add some tests for this! |
quba42
force-pushed
the
retrieve_functionality
branch
2 times, most recently
from
cbec80f
to
16b2cfc
Compare
hstct
reviewed
Mar 4, 2024
quba42
force-pushed
the
retrieve_functionality
branch
from
16b2cfc
to
d280a5d
Compare
hstct
reviewed
Mar 4, 2024
quba42
force-pushed
the
retrieve_functionality
branch
2 times, most recently
from
253bd3d
to
d46fd08
Compare
closes pulp#1010 In particular we are adding the new behaviour for: - ReleaseArchitecture - ReleaseComponent but deliberately not for PackageReleaseComponent, which should only be created indirectly using package actions.
quba42
force-pushed
the
retrieve_functionality
branch
from
d46fd08
to
599104f
Compare
hstct
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.