Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_VerifySignature on devel #64

Merged
merged 1 commit into from Jan 16, 2019

Conversation

quba42
Copy link
Collaborator

@quba42 quba42 commented Jan 3, 2019

The test_VerifySignature test will not run on my devel_pulp2_dev Vagrant box without this line.
Instead it throws a raise Exception("No GPG-keys in keyring, did the import fail?").
Since Travis appears to be doing fine without this fix, it would be good to know if others are having the same problem, or what the difference between Travis and my local Vagrant box is...

Edit: I added a pulp.plan.io issue to go with this PR:
https://pulp.plan.io/issues/4332

@pulpbot
Copy link
Member

pulpbot commented Jan 3, 2019

Can one of the admins verify this patch?

1 similar comment
@pulpbot
Copy link
Member

pulpbot commented Jan 3, 2019

Can one of the admins verify this patch?

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds rasonable to have.
It just does not explain, why travis passes without.

@mibanescu
Copy link
Member

A riddle, wrapped in a mystery. Thanks!

@mibanescu mibanescu merged commit 26af937 into pulp:master Jan 16, 2019
@quba42 quba42 deleted the fix_devel_testing branch January 18, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants