Merge colliding structure content #760
Conversation
|
Important: This initial draft pull request adds the code changes with an automatically generated migration. This migration will fail for most existing data, since we need to fix any colliding content and all foreign keys pointing at it, before we can alter the uniqueness constraints. |
quba42
added
.misc
quba42
force-pushed
the
structure_problem_migration
branch
3 times, most recently
from
df8d06f
to
9ad7522
Compare
|
We now have a working state for the DB migration. However, I have yet to introduce batching. Once this is done the migration requires performance testing with installations with large amounts of APT content. |
quba42
force-pushed
the
structure_problem_migration
branch
2 times, most recently
from
a2fec73
to
f5c6018
Compare
quba42
force-pushed
the
structure_problem_migration
branch
4 times, most recently
from
2711a69
to
ba27a37
Compare
pulp_deb/app/migrations/0025_merge_colliding_structure_content.py
Outdated
Show resolved
Hide resolved
quba42
force-pushed
the
structure_problem_migration
branch
3 times, most recently
from
c66d912
to
0243b8d
Compare
|
Ugh. Why are the tests now failing. These were already green before. It looks suspiciously like some change somewhere else broke this test. |
|
This looks like a good candidate for what broke the tests: pulp/pulpcore#3904 |
|
I think it is because the hosted data fixtures got updated? I ran into the same problem with the converted publish tests last week this is what i did to fix it for now: https://github.com/pulp/pulp_deb/pull/776/files#diff-39a085d2db2d6234c049924d46d2c3bac7ef2029a532cb9aa0e09d3a4a91f282R443 But it still worked for the pre conversion tests. I made a note to talk about this with you :) The essentials field is definitely in the pkg metadata though I checked. Maybe it is new because of Either way the field doesn't seem to get published. It is a valid field though https://www.debian.org/doc/debian-policy/ch-controlfields.html#essential |
[noissue]
closes pulp#599 Includes a DB migration that re-writes any colliding structure content, thus altering existing repository versions. So re-written repo versions will result in structurally identical publications, as compared to before the change. The only difference is that post-migration publications will lose any duplicate package paragraphs. This change will be released as part of pulp_deb version 3.0.0!
quba42
force-pushed
the
structure_problem_migration
branch
from
0243b8d
to
c2de7cc
Compare
closes #599
This will require a DB migration that alters the structure content in existing repository versions.
The plan is to release this change as pulp_deb 3.0.0!