Remove /usr/lib/pulp/plugins/types/deb.json from setup.py #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
I think, we can complete remove the file from the repository, not just not installing it. |
quba42
added a commit
to ATIX-AG/pulp-packaging
that referenced
this pull request
Jun 11, 2019
This file is a legacy way to provide plugin type definitions and is no longer needed. The presence of this file will break reindex migrations. WARNING: Also requires a change in pulp_deb: pulp/pulp_deb#93 fixes #4951 https://pulp.plan.io/issues/4951
quba42
added a commit
to ATIX-AG/pulp-packaging
that referenced
this pull request
Jun 11, 2019
This file is a legacy way to provide plugin type definitions and is no longer needed. The presence of this file will break reindex migrations. WARNING: Also requires a change in pulp_deb: pulp/pulp_deb#93 fixes #4951 https://pulp.plan.io/issues/4951
|
I also added a PR to pulp-packaging: |
quba42
force-pushed
the
type_file_packaging
branch
from
d890fff
to
ce44de8
Compare
|
Updated to reflect @mdellweg's suggestion. |
This legacy file will prevent migration 0004 from working. WARNING: This will also require removing the file from the .spec file in pulp-packaging repository! fixes #4951 https://pulp.plan.io/issues/4951
quba42
force-pushed
the
type_file_packaging
branch
from
ce44de8
to
f7cbe4a
Compare
|
ok test |
mibanescu
approved these changes
Jun 24, 2019
mdellweg
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This legacy file will prevent migration 0004 from working.
WARNING: This will also require removing the file from the .spec file in
pulp-packaging repository!
fixes #4951
https://pulp.plan.io/issues/4951
I recommend we hold out on merging this until we have had some reaction from the pulp-packaging maintainers.